linux-kernel - Re: [ 04/21] target/pscsi: Fix page increment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1363399822.3937.161.camel@deadeye.wl.decadent.org.uk>
Date:	Sat, 16 Mar 2013 02:10:22 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Asias He <asias@...hat.com>,
	Nicholas Bellinger <nab@...ux-iscsi.org>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [ 04/21] target/pscsi: Fix page increment

On Tue, 2013-03-12 at 15:44 -0700, Greg Kroah-Hartman wrote:
> 3.0-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Asias He <asias@...hat.com>
> 
> commit 472b72f2db7831d7dbe22ffdff4adee3bd49b05d upstream.
> 
> The page++ is wrong. It makes bio_add_pc_page() pointing to a wrong page
> address if the 'while (len > 0 && data_len > 0) { ... }' loop is
> executed more than one once.
> 
> Signed-off-by: Asias He <asias@...hat.com>
> Signed-off-by: Nicholas Bellinger <nab@...ux-iscsi.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> ---
>  drivers/target/target_core_pscsi.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/target/target_core_pscsi.c
> +++ b/drivers/target/target_core_pscsi.c
> @@ -1210,7 +1210,6 @@ static int __pscsi_map_task_SG(
>  				bio = NULL;
>  			}
>  
> -			page++;
>  			len -= bytes;
>  			data_len -= bytes;
>  			off = 0;

So in case a fragment crosses a page boundary, we wrap around to the
beginning of the same page?  That doesn't look right.

Ben.

-- 
Ben Hutchings
It is easier to change the specification to fit the program than vice versa.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)