[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130316083952.GO9138@mwanda>
Date: Sat, 16 Mar 2013 11:39:52 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Eduardo Valentin <eduardo.valentin@...com>
Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org
Subject: Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling
threshold values
On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote:
> if (ret) {
> dev_err(bg_ptr->dev, "failed to read thot\n");
> - return -EIO;
> + ret = -EIO;
> + goto exit;
> }
>
> - *thot = temp;
> + *val = temp;
>
> +exit:
> return 0;
> }
The bunny hop has introduced a bug and this always returns success.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists