linux-kernel - Re: [PATCH 13/19] f2fs: fix return value of releasepage for node and data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Mar 2013 20:59:02 +0900
From:	Jaegeuk Kim <jaegeuk.kim@...sung.com>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [PATCH 13/19] f2fs: fix return value of releasepage for node and
 data

2013-03-18 (월), 20:39 +0900, Namjae Jeon:
> 2013/3/18, Jaegeuk Kim <jaegeuk.kim@...sung.com>:
> > If the return value of releasepage is equal to zero, the page cannot be
> > reclaimed.
> > Instead, we should return 1 in order to reclaim clean pages.
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk.kim@...sung.com>
> > ---
> >  fs/f2fs/data.c |  4 +++-
> >  fs/f2fs/node.c | 13 +++----------
> >  2 files changed, 6 insertions(+), 11 deletions(-)
> >
> > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> > index 6616137..cd6b2cc 100644
> > --- a/fs/f2fs/data.c
> > +++ b/fs/f2fs/data.c
> > @@ -680,8 +680,10 @@ static void f2fs_invalidate_data_page(struct page
> > *page, unsigned long offset)
> >
> >  static int f2fs_release_data_page(struct page *page, gfp_t wait)
> >  {
> > +	if (PageWriteback(page))
> > +		return 0;
> >  	ClearPagePrivate(page);
> > -	return 0;
> > +	return 1;
> >  }
> I have a question.
> Although PageWriteback is already checked in try_to_release_page,
> we need to check it again in f2fs_release_data_page ?

Oh, I made a mistake.
No need to check that.
Thanks,

> 
> Thanks.
> 
> 
> > 1.8.1.3.566.gaa39828
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Jaegeuk Kim
Samsung

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)