linux-kernel - Re: [PATCH 5/7] usb: phy: tegra: get ULPI reset GPIO info using DT.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5147102F.1060204@cogentembedded.com>
Date:	Mon, 18 Mar 2013 17:01:35 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Venu Byravarasu <vbyravarasu@...dia.com>
CC:	gregkh@...uxfoundation.org, stern@...land.harvard.edu,
	balbi@...com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, swarren@...dotorg.org,
	linux-tegra@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH 5/7] usb: phy: tegra: get ULPI reset GPIO info using DT.

Hello.

On 18-03-2013 16:29, Venu Byravarasu wrote:

> As GPIO information is avail through DT, used it to get Tegra ULPI
> reset GPIO number. Added a new member to tegra_usb_phy structure to
> store this number.

> Signed-off-by: Venu Byravarasu <vbyravarasu@...dia.com>
> ---
>   drivers/usb/phy/tegra_usb_phy.c   |   25 +++++++++++--------------
>   include/linux/usb/tegra_usb_phy.h |    1 +
>   2 files changed, 12 insertions(+), 14 deletions(-)

> diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c
> index b5b2037..29c5ac4 100644
> --- a/drivers/usb/phy/tegra_usb_phy.c
> +++ b/drivers/usb/phy/tegra_usb_phy.c
[...]
> @@ -622,18 +619,18 @@ static int	tegra_phy_init(struct usb_phy *x)
[...]
> -		gpio_request(ulpi_config->reset_gpio, "ulpi_phy_reset_b");
> -		gpio_direction_output(ulpi_config->reset_gpio, 0);
> +		gpio_request(phy->reset_gpio, "ulpi_phy_reset_b");
> +		gpio_direction_output(phy->reset_gpio, 0);

    Why not use goio_request_one() instead of these two? Thought maybe it's a 
material of another patch...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/