linux-kernel - Re: [PATCH] x86: mm: add_pfn_range_mapped: use meaningful index to teach clean_sort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Mar 2013 11:52:52 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Lin Feng <linfeng@...fujitsu.com>
Cc:	akpm@...ux-foundation.org, linux-mm@...ck.org, x86@...nel.org,
	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, penberg@...nel.org, jacob.shin@....com
Subject: Re: [PATCH] x86: mm: add_pfn_range_mapped: use meaningful index to
 teach clean_sort_range()

On Mon, Mar 18, 2013 at 3:21 AM, Lin Feng <linfeng@...fujitsu.com> wrote:
> Since add_range_with_merge() return the max none zero element of the array, it's
> suffice to use it to instruct clean_sort_range() to do the sort. Or the former
> assignment by add_range_with_merge() is nonsense because clean_sort_range()
> will produce a accurate number of the sorted array and it never depends on
> nr_pfn_mapped.
>
> Cc: Jacob Shin <jacob.shin@....com>
> Cc: Yinghai Lu <yinghai@...nel.org>
> Signed-off-by: Lin Feng <linfeng@...fujitsu.com>
> ---
>  arch/x86/mm/init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> index 59b7fc4..55ae904 100644
> --- a/arch/x86/mm/init.c
> +++ b/arch/x86/mm/init.c
> @@ -310,7 +310,7 @@ static void add_pfn_range_mapped(unsigned long start_pfn, unsigned long end_pfn)
>  {
>         nr_pfn_mapped = add_range_with_merge(pfn_mapped, E820_X_MAX,
>                                              nr_pfn_mapped, start_pfn, end_pfn);
> -       nr_pfn_mapped = clean_sort_range(pfn_mapped, E820_X_MAX);
> +       nr_pfn_mapped = clean_sort_range(pfn_mapped, nr_pfn_mapped);
>
>         max_pfn_mapped = max(max_pfn_mapped, end_pfn);>

Acked-by: Yinghai Lu <yinghai@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/