linux-kernel - Re: [Patch v1] rtc: fix for the DA9052 rtc device registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130318152145.3a458537db6c4799311a2143@linux-foundation.org>
Date:	Mon, 18 Mar 2013 15:21:45 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ashish Jangam <ashish.jangam@...tcummins.com>
Cc:	<linux-kernel@...r.kernel.org>, <sameo@...ux.intel.com>,
	<p_gortmaker@...oo.com>, <dchen@...semi.com>,
	<rtc-linux@...glegroups.com>,
	Alessandro Zummo <a.zummo@...ertech.it>
Subject: Re: [Patch v1] rtc: fix for the DA9052 rtc device registration

On Fri, 15 Mar 2013 13:59:39 +0530 Ashish Jangam <ashish.jangam@...tcummins.com> wrote:

> DA9052/53 MFD core handles only virtual irq therefore rtc driver needs
> to be updated to work on virtual irq. Without this update DA9052/53 rtc 
> driver will fail during its registration.
> Also getting irq by it name is no longer supported in DA9052/53 core.
> 
> ...
>
> --- a/drivers/rtc/rtc-da9052.c
> +++ b/drivers/rtc/rtc-da9052.c
> @@ -239,10 +239,10 @@ static int da9052_rtc_probe(struct platform_device *pdev)
>  
>  	rtc->da9052 = dev_get_drvdata(pdev->dev.parent);
>  	platform_set_drvdata(pdev, rtc);
> -	rtc->irq = platform_get_irq_byname(pdev, "ALM");
> -	ret = request_threaded_irq(rtc->irq, NULL, da9052_rtc_irq,
> -				   IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> -				   "ALM", rtc);
> +	rtc->irq =  DA9052_IRQ_ALARM;
> +
> +	ret = da9052_request_irq(rtc->da9052, rtc->irq, "ALM",
> +				da9052_rtc_irq, rtc);
>  	if (ret != 0) {
>  		rtc_err(rtc->da9052, "irq registration failed: %d\n", ret);
>  		return ret;

drivers/rtc/rtc-da9052.c was converted to use
devm_request_threaded_irq() after linux-3.8, so I cannot apply this
patch to mainline.  Can you please prepare a patch against 3.9-rc3?

Do you believe that the patch should be backported into -stable
kernels?  If so, Greg will need a different version of it - ie, the one
you have just sent.  Please send that to him at the appropriate time
(say, when you see me drop the 3.9-rc3 version from the -mm tree).




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/