linux-kernel - Re: [PATCH 2/2] extcon: max8997: add missing const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK9yfHxMf8+Kb6qup70M+iOGznH6AVgKMRf8+xXa757oxQZdQQ@mail.gmail.com>
Date:	Tue, 19 Mar 2013 09:03:26 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] extcon: max8997: add missing const

On 19 March 2013 07:33, Jingoo Han <jg1.han@...sung.com> wrote:
> Fixed the checkpatch warning as below:
>
>   WARNING: static const char * array should probably be static const char * const
>   #163: FILE: drivers/extcon/extcon-max8997.c:163:
>   +static const char *max8997_extcon_cable[] = {
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/extcon/extcon-max8997.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index 20772ad..6e8724f 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -160,7 +160,7 @@ enum {
>         _EXTCON_CABLE_NUM,
>  };
>
> -static const char *max8997_extcon_cable[] = {
> +static const char const *max8997_extcon_cable[] = {

Shouldn't this be "static const char * const max8997_extcon_cable[]"
as suggested by checkpatch (as mentioned in your commit log)?


-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/