linux-kernel - [PATCH][RESEND] lib/kobject: save old kobject name when rename failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1363675756-31528-1-git-send-email-haodong@linux.vnet.ibm.com>
Date:	Tue, 19 Mar 2013 14:49:16 +0800
From:	Dong Hao <haodong@...ux.vnet.ibm.com>
To:	gregkh@...uxfoundation.org
Cc:	linux-kernel@...r.kernel.org, Dong Hao <haodong@...ux.vnet.ibm.com>
Subject: [PATCH][RESEND] lib/kobject: save old kobject name when rename failure 

From: Dong Hao <haodong@...ux.vnet.ibm.com>

Function kobject_set_name_vargs() was implemented to rename the existing kobject.
It depends on kvasprintf() which might return NULL, so it's possible that kobject name
becomes NULL and in that case we will lose the old name.

This patch restores the old name when kvasprintf() returns NULL.

Signed-off-by: Dong Hao <haodong@...ux.vnet.ibm.com>
---
 lib/kobject.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/kobject.c b/lib/kobject.c
index f7d9f31..6e0186f 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -220,8 +220,10 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
 		return 0;
 
 	kobj->name = kvasprintf(GFP_KERNEL, fmt, vargs);
-	if (!kobj->name)
+	if (!kobj->name) {
+		kobj->name = old_name;
 		return -ENOMEM;
+	}
 
 	/* ewww... some of these buggers have '/' in the name ... */
 	while ((s = strchr(kobj->name, '/')))
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/