linux-kernel - Re: [PATCH] target: close target_put_sess_cmd() vs. core_tmr_abort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130319002742.GA11050@kroah.com>
Date:	Mon, 18 Mar 2013 17:27:42 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Jörn Engel <joern@...fs.org>
Cc:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	linux-kernel@...r.kernel.org,
	target-devel <target-devel@...r.kernel.org>
Subject: Re: [PATCH] target: close target_put_sess_cmd() vs.
 core_tmr_abort_task() race

On Mon, Mar 18, 2013 at 06:56:57PM -0400, Jörn Engel wrote:
> On Mon, 18 March 2013 17:04:11 -0700, Greg Kroah-Hartman wrote:
> > On Mon, Mar 18, 2013 at 06:28:53PM -0400, Jörn Engel wrote:
> > > It is possible for one thread to to take se_sess->sess_cmd_lock in
> > > core_tmr_abort_task() before taking a reference count on
> > > se_cmd->cmd_kref, while another thread in target_put_sess_cmd() drops
> > > se_cmd->cmd_kref before taking se_sess->sess_cmd_lock.
> > > 
> > > This introduces kref_put_and_lock() and uses it in
> > > target_put_sess_cmd() to close the race window.
> > 
> > We already have kref_put_mutex(), why not just call this
> > kref_put_spinlock()?
> 
> Back when I originally wrote this patch, kref_put_mutex() didn't exist
> yet.  So there is my evil predetermined plan to introduce random
> inconsistencies by being consistent with atomic_dec_and_lock()
> instead.

Don't be evil, leave that up to the professionals :)

> If you think this matters I can rename the function and resend.

Please do, it is good to name things correctly, when we have the chance.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/