linux-kernel - [PATCH] usb: phy: samsung-usb2: Fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 19 Mar 2013 14:45:17 +0530
From:	Vivek Gautam <gautam.vivek@...sung.com>
To:	linux-usb@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	Fengguang Wu <fengguang.wu@...el.com>,
	Christopher Li <sparse@...isli.org>,
	Felipe Balbi <balbi@...com>
Subject: [PATCH] usb: phy: samsung-usb2: Fix sparse warning

Fixing the following sparse warning:

sparse warnings: (new ones prefixed by >>)

>> drivers/usb/phy/phy-samsung-usb2.c:50:26: sparse: incorrect type in argument 1 (different address spaces)
   drivers/usb/phy/phy-samsung-usb2.c:50:26:    expected void const volatile [noderef] <asn:2>*addr
   drivers/usb/phy/phy-samsung-usb2.c:50:26:    got void *
>> drivers/usb/phy/phy-samsung-usb2.c:73:35: sparse: incorrect type in argument 1 (different address spaces)
   drivers/usb/phy/phy-samsung-usb2.c:73:35:    expected void *regs
   drivers/usb/phy/phy-samsung-usb2.c:73:35:    got void [noderef] <asn:2>*regs

Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com>
CC: Fengguang Wu <fengguang.wu@...el.com>
CC: Christopher Li <sparse@...isli.org>
CC: Felipe Balbi <balbi@...com>
---

Based on 'next' branch of Felipe's usb tree.
Tested using make C=2 drivers/usb/phy/phy-samsung-usb2.o

Hi Felipe,

Sorry to bug you for this small change, i think this got unnoticed in the
last cycle too. Fixing it now.

Thanks
Vivek

 drivers/usb/phy/phy-samsung-usb2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/phy/phy-samsung-usb2.c b/drivers/usb/phy/phy-samsung-usb2.c
index dce9681..45ffe03 100644
--- a/drivers/usb/phy/phy-samsung-usb2.c
+++ b/drivers/usb/phy/phy-samsung-usb2.c
@@ -43,7 +43,7 @@ static int samsung_usbphy_set_host(struct usb_otg *otg, struct usb_bus *host)
 	return 0;
 }
 
-static bool exynos5_phyhost_is_on(void *regs)
+static bool exynos5_phyhost_is_on(void __iomem *regs)
 {
 	u32 reg;
 
-- 
1.7.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/