linux-kernel - Re: [PATCH 1/1] extcon: max77693: Staticize default_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <5148316D.9040801@samsung.com>
Date:	Tue, 19 Mar 2013 18:35:41 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	linux-kernel@...r.kernel.org, myungjoo.ham@...sung.com
Subject: Re: [PATCH 1/1] extcon: max77693: Staticize default_init_data

On 03/19/2013 01:07 PM, Sachin Kamat wrote:
> Commit 0ec83bd246 ("extcon: max77693: Initialize register of MUIC
> device to bring up it without platform data") added this structure
> but forgot to make it static. Without this patch we get the following
> warning:
> drivers/extcon/extcon-max77693.c:41:26: warning:
> symbol 'default_init_data' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> ---
>  drivers/extcon/extcon-max77693.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
> index 8f3c947..7b2e93d 100644
> --- a/drivers/extcon/extcon-max77693.c
> +++ b/drivers/extcon/extcon-max77693.c
> @@ -38,7 +38,7 @@
>   * extcon-max77693 driver use 'default_init_data' to bring up base operation
>   * of MAX77693 MUIC device.
>   */
> -struct max77693_reg_data default_init_data[] = {
> +static struct max77693_reg_data default_init_data[] = {
>  	{
>  		/* STATUS2 - [3]ChgDetRun */
>  		.addr = MAX77693_MUIC_REG_STATUS2,
Applied it. Thanks.

Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/