linux-kernel - Re: [PATCH v2 1/2] extcon: max8997: use dev_err() instead of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <51483184.6070009@samsung.com>
Date:	Tue, 19 Mar 2013 18:36:04 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	'MyungJoo Ham' <myungjoo.ham@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] extcon: max8997: use dev_err() instead of pr_err()

On 03/19/2013 02:30 PM, Jingoo Han wrote:
> dev_err() is more preferred than pr_err().
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
> No Changes since v1:
>
>  drivers/extcon/extcon-max8997.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index 69641bc..20772ad 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -646,7 +646,7 @@ static void max8997_muic_detect_cable_wq(struct work_struct *work)
>  
>  	ret = max8997_muic_detect_dev(info);
>  	if (ret < 0)
> -		pr_err("failed to detect cable type\n");
> +		dev_err(info->dev, "failed to detect cable type\n");
>  }
>  
>  static int max8997_muic_probe(struct platform_device *pdev)
Applied it. Thanks.

Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/