linux-kernel - Re: [Xen-devel] [PATCH 1/5] xen-blkback: don't store dev_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5148912802000078000C6CC4@nat28.tlf.novell.com>
Date:	Tue, 19 Mar 2013 15:24:08 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Konrad Rzeszutek Wilk" <konrad.wilk@...cle.com>
Cc:	"Roger Pau Monne" <roger.pau@...rix.com>,
	<xen-devel@...ts.xen.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH 1/5] xen-blkback: don't store
 dev_bus_addr

>>> On 19.03.13 at 16:10, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> wrote:
> On Tue, Mar 19, 2013 at 02:55:56PM +0000, Jan Beulich wrote:
>> >>> On 19.03.13 at 15:32, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> wrote:
>> > @@ -971,7 +962,7 @@ static int dispatch_rw_block_io(struct xen_blkif *blkif,
>> >  		       (bio_add_page(bio,
>> >  				     pages[i],
>> >  				     seg[i].nsec << 9,
>> > -				     seg[i].buf & ~PAGE_MASK) == 0)) {
>> > +				     seg[i].offset & ~PAGE_MASK) == 0)) {
>> 
>> ... this one could as well use the original field.
>> 
>> And the masking with ~PAGE_MASK is not pointless in any case.
> 
> Good point. In which might as well make the 'struct seg_buf' be an
> simple array of unsigned int.

Looks like you understood that the "not" in my earlier response
was meant to be "now".

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/