| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Mar 2013 09:44:24 -0600 From: Stephen Warren <swarren@...dotorg.org> To: Laxman Dewangan <ldewangan@...dia.com> CC: sameo@...ux.intel.com, swarren@...dia.com, broonie@...nsource.wolfsonmicro.com, gg@...mlogic.co.uk, linux-kernel@...r.kernel.org Subject: Re: [PATCH] mfd: palmas: initialise client->of_node for dummy created client On 03/19/2013 02:58 AM, Laxman Dewangan wrote: > Palmas device have three different i2c addresses. The device creates > the two new dummy i2c clients for accessing the register by using > primary client adapter. This new dummy i2c client have their of_node > as NULL. > > The dummy i2c client is used for registering interrupt and on this, > it creates irq domain handle. This created irq domain handle has > their of_node as NULL. It seems like part of the solution here is to modify the i2c_client object itself so that it can directly support devices that have multiple I2C addresses; instead of 1 i2c_client representing 1 address, 1 i2c_client could represent a list of addresses, that list being populated directly from the list contained in the top-level node's reg property. That way, you wouldn't need any dummy i2c_clients, which would avoid this issue. If the I2C device itself has multiple I2C addresses, they really should all be explicitly listed in the device tree reg property. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists