linux-kernel - Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1303191142330.15684-100000@netrider.rowland.org>
Date:	Tue, 19 Mar 2013 11:48:07 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Yuan-Hsin Chen <yuanlmm@...il.com>
cc:	Felipe Balbi <balbi@...com>, <gregkh@...uxfoundation.org>,
	<sarah.a.sharp@...ux.intel.com>, <Julia.Lawall@...6.fr>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Yuan-Hsin Chen <yhchen@...aday-tech.com>,
	<john453@...aday-tech.com>
Subject: Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

On Tue, 19 Mar 2013, Yuan-Hsin Chen wrote:

> > What about the port_status registers?  They're not between command and
> > async_next.  If they aren't consistent with EHCI, it makes things a lot
> > more complicated.
> 
> fusbh200 has only one port_status register with different offset,
> 0x30, and the position of some bits are different from EHCI.

That's pretty nasty.  Integrating that with the standard EHCI driver 
would be considerably more difficult.

Why was the FUSBH200 designed in this strange way?  Why doesn't it use 
the standard EHCI register layout?  Were the engineers at Faraday 
deliberately trying to make life harder for driver writers?

> Also, usbmode_ex, hostpc, and txfill_tuning other than configured_flag
> are non-existent in fusbh200. They are used in both ehci-hcd.c and
> ehci-hub.c for several times.

They are used only if the hardware supports them, that is, only if the
ehci->has_hostpc flag is set.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/