linux-kernel - RE: [PATCH] pm: print the name of failed suspend function for platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BEC9F67575FA1E429CA7CF5AE9BE3634421912@SHSMSX102.ccr.corp.intel.com>
Date:	Tue, 19 Mar 2013 02:05:02 +0000
From:	"Li, Fei" <fei.li@...el.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	"rjw@...k.pl" <rjw@...k.pl>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"ldewangan@...dia.com" <ldewangan@...dia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Liu, Chuansheng" <chuansheng.liu@...el.com>
Subject: RE: [PATCH] pm: print the name of failed suspend function for
 platform device

> > Print more info when platform device suspend function failed.
> > Without this patch, we can not get the real platform device suspend
> > API info.
> >
> > Example without this patch:
> > pm_op(): platform_pm_suspend+0x0/0x50 returns -11
> > PM: Device power.0 failed to suspend: error -11
> >
> > And with this patch:
> > platform_pm_suspend(): power_suspend+0x0/0x30 returns -11
> > pm_op(): platform_pm_suspend+0x0/0x80 returns -11
> > PM: Device power.0 failed to suspend: error -11
> 
> How does that help someone out?  One extra line?  What is that going to
> allow a user to now do?
>
Thanks for your comments.

The intention is to print relatively complete call path for convenience of
debugging in case of error. With this, we can know the exact name of
the concrete failed function.
Besides, currently such information is printed with level KERN_ERR,
and can be tuned through console_loglevel to avoid the possible impact
to end user.

Do you think it make sense?

Thanks and Regards,
Li Fei

> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/