linux-kernel - Re: [PATCH] usb: Make USB persist default configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAODwPW8bAo-ixwmJjGPT94kDVSb+4qO264mOXyZ5RjmisTkYFQ@mail.gmail.com>
Date:	Tue, 19 Mar 2013 10:29:40 -0700
From:	Julius Werner <jwerner@...omium.org>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Vincent Palatin <vpalatin@...omium.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>, linux-usb@...r.kernel.org,
	Lan Tianyu <tianyu.lan@...el.com>,
	Sameer Nanda <snanda@...omium.org>,
	Luigi Semenzato <semenzato@...omium.org>
Subject: Re: [PATCH] usb: Make USB persist default configurable

> Yes, okay, that's true.  If a new USB device is plugged in while the
> lid is shut, and then the lid is opened very briefly, it's possible
> that the system could suspend again before the new device's "persist"
> attribute is updated.  Does that case really matter?  The device isn't
> likely to be in use at that point.

It does matter if the device will be used after the next resume,
because that one would use the persist code. If there was a driver
problem it would fail, and if it was a USB stick that is swapped with
a different one of the same model, you could get file system
corruption.

I agree with you that buggy drivers should get fixed (and we are
trying to do that as well), but at the same time we want to be able to
have a system that can keep its policies at all times. We get a lot of
USB problems (especially around suspend/resume), and we don't want to
need to worry every time about which code path we hit and whether one
of those race conditions could have something to do with it. I'm
convinced that having this in the kernel is the cleanest solution for
us, and I just thought it might be useful to standardize a mechanism
for that (I don't really see the maintenance burden in that config
option either, as the persist mechanism itself does not look like it
was going to go away anytime soon).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/