linux-kernel - Re: [PATCH 1/3] kernel/srcu: merge common code into a macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5148AB59.6080000@linutronix.de>
Date:	Tue, 19 Mar 2013 19:15:53 +0100
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Joe Perches <joe@...ches.com>
CC:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	linux-kernel@...r.kernel.org, tglx@...utronix.de
Subject: Re: [PATCH 1/3] kernel/srcu: merge common code into a macro

On 03/19/2013 05:22 PM, Joe Perches wrote:
>> +#define DEFINE_SRCU(name)		_DEFINE_SRCU(name, )
>> +#define DEFINE_STATIC_SRCU(name)	_DEFINE_SRCU(name, static)
> 
> I think the use of an empty argument, even in
> a macro, unsightly.

__wait_event_lock_irq() => __wait_event_lock_irq() is a prominent user.
I would prefer to avoid adding something like /* nothing */.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/