linux-kernel - Re: [PATCH] usb: Make USB persist default configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Mar 2013 17:06:56 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Julius Werner <jwerner@...omium.org>
Cc:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	Lan Tianyu <tianyu.lan@...el.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Sameer Nanda <snanda@...omium.org>,
	Vincent Palatin <vpalatin@...omium.org>,
	Luigi Semenzato <semenzato@...omium.org>
Subject: Re: [PATCH] usb: Make USB persist default configurable

On Mon, Mar 18, 2013 at 05:02:19PM -0700, Julius Werner wrote:
> > Why can't you just revert this in userspace?  Isn't that easier than
> > doing a kernel patch and providing an option that we need to now
> > maintain for pretty much forever?
> 
> I could solve it in userspace, but that really feels like a hacky
> workaround and not a long term solution. It would mean that every new
> device starts with persist enabled and stays that way for a few
> milliseconds (maybe up to seconds if it's connected on boot), until
> userspace gets around to disable it again... opening the possibility
> for very weird race conditions and bugs with drivers/devices that
> don't work with persist.

What drivers/devices don't work with persist?  We need to know that now,
otherwise all other distros and users have problems, right?

> This default is a policy that really resides in the kernel, it has
> changed in the past, and since there is no definitive better choice
> for all cases I thought making it configurable is the right thing to
> do.

Too many options can be a bad thing.

I think Alan made this a "always on" option, so I'd like to get his
opinion on it.  Alan?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/