linux-kernel - Re: [PATCH] sparc: remove unused "config BITS"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Mar 2013 21:14:54 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	David Miller <davem@...emloft.net>, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sparc: remove unused "config BITS"

On Tue, Mar 19, 2013 at 06:06:47PM +0100, Paul Bolle wrote:
> On Tue, 2013-03-19 at 12:33 -0400, David Miller wrote:
> > We use this in the Makefile fragments, you cannot remove it.
> 
> >From arch/sparc/Makefile:
>     ifeq ($(CONFIG_SPARC32),y)
>     [...]
> 
>     [...]
>     export BITS    := 32
>     [...]
> 
>     else
>     [...]
> 
>     [...]
>     export BITS   := 64
>     [...]
> 
> So $(BITS) is set depending on whether CONFIG_SPARC32 is set or not.
> Using $(BITS) in sparc's Makefiles is not using CONFIG_BITS. That
> doesn't count as usage of "config BITS". 
Just double checked - you are right.
Maybe send a v2 with this info in changelog and add my:

Acked-by: Sam Ravnborg <sam@...nborg.org>

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/