linux-kernel - [PATCH wq/for-3.10] workqueue: define workqueue_freezing static variable iff CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130319210151.GM3042@htj.dyndns.org>
Date:	Tue, 19 Mar 2013 14:01:51 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: [PATCH wq/for-3.10] workqueue: define workqueue_freezing static
 variable iff CONFIG_FREEZER

>From a0265a7f5161b6cb55e82b71edb236bbe0d9b3ae Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@...nel.org>
Date: Tue, 19 Mar 2013 13:55:42 -0700

699ce097efe ("workqueue: implement and use pwq_adjust_max_active()")
replaced the only workqueue_freezing usage outside freezer callbacks
with a POOL_FREEZING test.  This makes workqueue_freezing unused when
!CONFIG_FREEZER leading to a compiler warning.  Define
workqueue_freezing iff CONFIG_FREEZER.

Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
Reported-by: Fengguang Wu <fengguang.wu@...el.com>
Signed-off-by: Tejun Heo <tj@...nel.org>
---
 kernel/workqueue.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index e38d035..775c2f4 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -261,7 +261,9 @@ static DEFINE_SPINLOCK(pwq_lock);	/* protects pool_workqueues */
 static DEFINE_SPINLOCK(wq_mayday_lock);	/* protects wq->maydays list */
 
 static LIST_HEAD(workqueues);		/* WQ: list of all workqueues */
+#ifdef CONFIG_FREEZER
 static bool workqueue_freezing;		/* WQ: have wqs started freezing? */
+#endif
 
 /* the per-cpu worker pools */
 static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS],
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/