linux-kernel - Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130320085241.GA10570@zurbaran>
Date:	Wed, 20 Mar 2013 09:52:41 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Simon Glass <sjg@...omium.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Rob Landley <rob@...dley.net>,
	Felipe Balbi <balbi@...com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Luigi Semenzato <semenzato@...omium.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Che-Liang Chiou <clchiou@...omium.org>,
	Jonathan Kliegman <kliegs@...omium.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	Sourav Poddar <sourav.poddar@...com>,
	Devicetree Discuss <devicetree-discuss@...ts.ozlabs.org>,
	Alban Bedel <alban.bedel@...onic-design.de>,
	Roland Stigge <stigge@...com.de>,
	Vincent Palatin <vpalatin@...omium.org>,
	Javier Martinez Canillas <javier@...hile0.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Tony Lindgren <tony@...mide.com>,
	Bill Pemberton <wfp5p@...ginia.edu>
Subject: Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support

Hi Simon,

On Wed, Mar 20, 2013 at 09:14:56AM +0100, Samuel Ortiz wrote:
> On Tue, Mar 19, 2013 at 07:01:42PM -0700, Simon Glass wrote:
> > Hi Samuel,
> > 
> > On Tue, Mar 19, 2013 at 6:12 PM, Samuel Ortiz <sameo@...ux.intel.com> wrote:
> > > On Wed, Mar 20, 2013 at 01:56:52AM +0100, Samuel Ortiz wrote:
> > >> Hi Simon,
> > >>
> > >> On Mon, Feb 25, 2013 at 02:08:35PM -0800, Simon Glass wrote:
> > >> > The ChromeOS Embedded Controller (EC) is an Open Source EC implementation
> > >> > used on ARM and Intel Chromebooks. Current implementations use a Cortex-M3
> > >> > connected on a bus (such as I2C, SPI, LPC) to the AP. A separate interrupt
> > >> > line is used to indicate when the EC needs service.
> > >> All 6 patches applied to my mfd-next tree, thanks a lot.
> > > Actually, this one fails to build when CONFIG_OF is not set:
> > >
> > > drivers/mfd/cros_ec_i2c.c:130:2: error: implicit declaration of function
> > > ‘of_device_is_available’ [-Werror=implicit-function-declaration]
> > >
> > > If the check in cros_ec_probe_i2c() is really needed then you'll need to inline
> > > of_device_is_available() into a NOP in include/linux/of.h.
> > 
> > Actually I suppose that call is not really needed. Would you like to
> > remove it, or shall I send a new patch?
> I will remove it.
This is fixed and pushed. I also fixed some warnings and another build failure
for the case when all of your code is modular.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/