linux-kernel - Re: [PATCH 2/2] regulator: palmas: add input supply names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Mar 2013 18:24:54 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Stephen Warren <swarren@...dia.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"lrg@...com" <lrg@...com>
Subject: Re: [PATCH 2/2] regulator: palmas: add input supply names

On Wednesday 20 March 2013 06:01 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Mon, Mar 18, 2013 at 02:59:48PM +0530, Laxman Dewangan wrote:
>
> There's something odd about several recent patch serieses you've posted,
> they end up with patch 2 before instead of after patch 1.  Anyway...

I generally send a patches on single git-send command
git send-emal --to=ldewangan@...dia.com 0000.patch 0001.patch

So file names are in seq but not sure why it is not on seq. Something 
mail exchange  resuffle.
Probably I need to send one by one...

>
>> +		if (config.init_data)
>> +			pmic->desc[id].supply_name = palmas_regs_info[id].sname;
>> +
> This looks wrong...  why is it conditional on init_data?

Some of the rails are not used in board and hence their inputs are also 
left floating (unconnected). In this case, during DT population, I did 
not put entry
i.e. if ldo1 is not used then ldo1-in is not connected on board and hence
entry on DT

ldo1-in-supply=<&xyzreg>;

is not there.

The regulator core register the regulator even if there is NULL 
init_data and in this case, it tries to findout the input-supply 
(provided through desc->supply_name) and it fails to find out the supply 
handle and so regulator register fails cause all regulator registration 
to fail.

So providing the dec->supply_name only in case of valid init_data.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/