linux-kernel - Re: [PATCH] drivers: video: omap2: dss: Use PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5149D95D.2030505@ti.com>
Date:	Wed, 20 Mar 2013 10:44:29 -0500
From:	Jon Hunter <jon-hunter@...com>
To:	Tomi Valkeinen <tomi.valkeinen@...com>
CC:	Alexandru Gheorghiu <gheorghiuandru@...il.com>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: video: omap2: dss: Use PTR_RET function


On 03/20/2013 06:56 AM, Tomi Valkeinen wrote:
> On 2013-03-19 10:03, Alexandru Gheorghiu wrote:
>> Use PTR_RET function instead of IS_ERR and PTR_ERR.
>> Patch found using coccinelle.
>>
>> Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@...il.com>
>> ---
>>  drivers/video/omap2/dss/core.c |    5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
>> index f8779d4..60cc6fe 100644
>> --- a/drivers/video/omap2/dss/core.c
>> +++ b/drivers/video/omap2/dss/core.c
>> @@ -181,10 +181,7 @@ int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *))
>>  	d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir,
>>  			write, &dss_debug_fops);
>>  
>> -	if (IS_ERR(d))
>> -		return PTR_ERR(d);
>> -
>> -	return 0;
>> +	return PTR_RET(d);
>>  }
>>  #else /* CONFIG_OMAP2_DSS_DEBUGFS */
>>  static inline int dss_initialize_debugfs(void)
>>
> 
> Thanks. I'll apply to omapdss tree.

Is this correct? If debugfs_create_file() returns a valid pointer, then
now dss_debugfs_create_file() will return a non-zero value on success. I
don't think this is what you want. A similar case came up recently here [1].

Jon

[1] http://comments.gmane.org/gmane.linux.kernel/1455141
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/