linux-kernel - Re: [PATCH] pciehp: Add pciehp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hmwtxq3ic.wl%tiwai@suse.de>
Date:	Wed, 20 Mar 2013 20:23:39 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Oliver Neukum <oneukum@...e.de>, Michal Marek <mmarek@...e.cz>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pciehp: Add pciehp_surprise module option

At Wed, 20 Mar 2013 19:12:50 +0000,
Matthew Garrett wrote:
> 
> On Wed, Mar 20, 2013 at 08:11:15PM +0100, Takashi Iwai wrote:
> > At Wed, 20 Mar 2013 17:52:34 +0000,
> > Matthew Garrett wrote:
> > > Well that just sounds like a bug. What's the downside to just ignoring 
> > > that capability bit?
> > 
> > I'm afraid that it's too radical to enable always.
> 
> Why?

Because I'm conservative :)
Well, dunno.  It's just my feeling without deep thought.

> > Or, what about to check this bit only for disable path?
> 
> What happens if you unplug the device on one of the affected machines?

It continues working.  I mean, the PCI device is still there after
unplug, but the Realtek driver unmounts it smoothly.  Re-plugging also
works, too.  So, the handling via pciehp is needed only for the very
first time to register the PCI device.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/