linux-kernel - Re: linux-next: build failure after merge of the final tree (cgroup tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130320154328.4b164061f7a58af5fb3f62e4@canb.auug.org.au>
Date:	Wed, 20 Mar 2013 15:43:28 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Tejun Heo <tj@...nel.org>
Cc:	Li Zefan <lizefan@...wei.com>, <linux-next@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the final tree (cgroup
 tree related)

Hi all,

On Wed, 13 Mar 2013 14:33:15 +0800 Li Zefan <lizefan@...wei.com> wrote:
>
> On 2013/3/13 13:12, Stephen Rothwell wrote:
> > 
> > After merging the final tree, today's linux-next build (powerpc
> > allnoconfig) failed like this:
> > 
> > In file included from include/linux/memcontrol.h:22:0,
> >                  from include/linux/swap.h:8,
> >                  from include/linux/suspend.h:4,
> >                  from arch/powerpc/kernel/asm-offsets.c:24:
> > include/linux/cgroup.h:748:13: warning: 'struct cgroupstats' declared inside parameter list [enabled by default]
> > include/linux/cgroup.h:748:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> > cc1: all warnings being treated as errors
> > 
> > and many more similar.
> > 
> > Caused by commit c2c9ad164fa3 ("cgroup: remove unneeded includes from
> > cgroup.h").
> > 
> 
> Tejun has dropped this patch.

It has returned today.  Please be more careful.

In file included from include/linux/memcontrol.h:22:0,
                 from include/linux/swap.h:8,
                 from include/linux/suspend.h:4,
                 from arch/powerpc/kernel/asm-offsets.c:24:
include/linux/cgroup.h:742:13: warning: 'struct cgroupstats' declared inside parameter list [enabled by default]
include/linux/cgroup.h:742:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

I have reverted commit c2c9ad164fa3 ("cgroup: remove unneeded includes
from cgroup.h") for today.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped