linux-kernel - Re: [PATCH v4 0/3] dmaengine: add slave sg transfer limits api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Mar 2013 12:16:43 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Matt Porter <mporter@...com>
Cc:	Chris Ball <cjb@...top.org>, Dan Williams <djbw@...com>,
	Sekhar Nori <nsekhar@...com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Linux DaVinci Kernel List 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux MMC List <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH v4 0/3] dmaengine: add slave sg transfer limits api

On Wed, Mar 06, 2013 at 02:56:04PM -0500, Matt Porter wrote:
> Changes since v3:
> 	- Change api name to dma_get_slave_sg_limits() to avoid
> 	  confusion with h/w caps which are static.
> 
> Changes since v2:
> 	- Change to a separate slave sg specific api. Drop the
> 	  generic per-channel capabilities api that is not used.
> 
> Changes since v1:
> 	- Use the existing dma_transaction_type enums instead of
> 	  adding the mostly duplicated dmaengine_apis enums
> 
> This series adds a new dmaengine api, dma_get_slave_sg_limits(), which
> may be used by a client driver to get slave SG transfer limits for a
> particular channel. At this time, these include the max number of
> segments and max length of a segment that a channel can handle for a
> SG transfer.
Looks fine, should be ready for merge once we fix the API.
Also I was under the impression that you will add another API to calculate the
limits, the stuff which you were doing in caps API earlier.

--
~Vinod
> 
> Along with the API implementation, this series implements the backend
> device_slave_sg_limits() in the EDMA DMA Engine driver and converts the
> davinci_mmc driver to use dma_get_slave_sg_limits() to replace hardcoded
> limits.
> 
> This is tested on the AM1808-EVM.
> 
> Matt Porter (3):
>   dmaengine: add dma_get_slave_sg_limits()
>   dma: edma: add device_slave_sg_limits() support
>   mmc: davinci: get SG segment limits with dma_get_slave_sg_limits()
> 
>  drivers/dma/edma.c                        |   17 +++++++++++++
>  drivers/mmc/host/davinci_mmc.c            |   37 ++++++++-------------------
>  include/linux/dmaengine.h                 |   39 +++++++++++++++++++++++++++++
>  include/linux/platform_data/mmc-davinci.h |    3 ---
>  4 files changed, 66 insertions(+), 30 deletions(-)
> 
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/