linux-kernel - Re: [PATCH] DMA: OF: Check properties value before running be32_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Mar 2013 15:48:50 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	linaro-kernel@...ts.linaro.org, spear-devel@...t.st.com,
	linux-kernel@...r.kernel.org, rob.herring@...xeda.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] DMA: OF: Check properties value before running
 be32_to_cpup() on it

On 21 March 2013 15:16, Vinod Koul <vinod.koul@...el.com> wrote:
> On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote:
>> In of_dma_controller_register() routine we are calling of_get_property() as an
>> parameter to be32_to_cpup(). In case the property doesn't exist we will get a
>> crash.
>>
>> This patch changes this code to check if we got a valid property first and then
>> runs be32_to_cpup() on it.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
>> ---
>>
>> My mails are broken, i have pushed this patch here:
> I noticed you used git send-email. Usually it will send patch properly
> independent of whatever MUA you use.

Probably not!! Its the famous (Infamous) Microsoft exchange server working in
background and it breaks mails without treating mails coming from git send-email
specially :)

> So I have the patch and its applied now :)

I have seen this kind of discrimination on breaking patches based on the size of
patch. If its very small (like this one), you may get a unbroken patch
but if the size
is a bit large then nobody can save you :)

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/