linux-kernel - Re: [PATCH 2/2] PM / devfreq: tie suspend/resume to runtime-pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1303211101530.1899-100000@iolanthe.rowland.org>
Date:	Thu, 21 Mar 2013 11:02:57 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Rajagopal Venkat <rajagopal.venkat@...aro.org>
cc:	myungjoo.ham@...sung.com, <rjw@...k.pl>,
	Kevin Hilman <khilman@...aro.org>,
	<linaro-kernel@...ts.linaro.org>, <linux-pm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] PM / devfreq: tie suspend/resume to runtime-pm

On Thu, 21 Mar 2013, Rajagopal Venkat wrote:

> Allow device devfreq to be suspend/resume automatically with
> runtime pm suspend/resume. The devfreq drivers should be least
> cared when to suspend/resume the devfreq.
> 
> pm_runtime_suspend(dev) will first suspend device devfreq(if available)
> before device is suspended from runtime pm core.
> 
> pm_runtime_resume(dev) will resume device devfreq(if available) after
> device is resumed from runtime pm core.

Aren't these backward?  The device continues to need its clocks and 
frequency settings until _after_ it has been suspended.  Similarly, it 
needs them to be available _before_ it resumes.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/