linux-kernel - Re: [PATCH v2] ioat: remove chanerr mask setting for IOAT v3.x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <514B4FCF.7080509@intel.com>
Date:	Thu, 21 Mar 2013 11:22:07 -0700
From:	Dave Jiang <dave.jiang@...el.com>
To:	Vinod Koul <vinod.koul@...el.com>
CC:	"djbw@...com" <djbw@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"Mason, Jon" <jon.mason@...el.com>
Subject: Re: [PATCH v2] ioat: remove chanerr mask setting for IOAT v3.x

On 03/20/2013 10:03 PM, Vinod Koul wrote:
> On Wed, Nov 28, 2012 at 03:46:08AM +0530, Jiang, Dave wrote:
>> The existing code set a value in the PCI_CHANERRMSK_INT register
>> for a workaround to address a pre-silicon bug on the Intel 5520 IO hub that
>> has been fixed when the hardware was released. There is no need for this
>> code.
>>
>> Signed-off-by: Dave Jiang <dave.jiang@...el.com>
>> ---
>>
>>   drivers/dma/ioat/dma_v3.c |    7 +------
>>   1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
>> index f7f1dc6..fda3b8a1 100644
>> --- a/drivers/dma/ioat/dma_v3.c
>> +++ b/drivers/dma/ioat/dma_v3.c
>> @@ -1126,12 +1126,7 @@ static int ioat3_reset_hw(struct ioat_chan_common *chan)
>>   	chanerr = readl(chan->reg_base + IOAT_CHANERR_OFFSET);
>>   	writel(chanerr, chan->reg_base + IOAT_CHANERR_OFFSET);
>>   
>> -	/* -= IOAT ver.3 workarounds =- */
>> -	/* Write CHANERRMSK_INT with 3E07h to mask out the errors
>> -	 * that can cause stability issues for IOAT ver.3, and clear any
>> -	 * pending errors
>> -	 */
> What is this code based against? i dont have above lines in -rc1 or my next?
Looking at the Linus tree it looks like it's already upstream somehow? 
Commit 6decffd.

>> -	pci_write_config_dword(pdev, IOAT_PCI_CHANERRMASK_INT_OFFSET, 0x3e07);
>> +	/* clear any pending errors */
>>   	err = pci_read_config_dword(pdev, IOAT_PCI_CHANERR_INT_OFFSET, &chanerr);
>>   	if (err) {
>>   		dev_err(&pdev->dev, "channel error register unreachable\n");
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/