linux-kernel - Re: [PATCHSET] idr: implement idr_alloc() and convert existing users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130321183513.GC20500@htj.dyndns.org>
Date:	Thu, 21 Mar 2013 11:35:13 -0700
From:	Tejun Heo <tj@...nel.org>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	rusty@...tcorp.com.au, skinsbursky@...allels.com,
	ebiederm@...ssion.com, jmorris@...ei.org, axboe@...nel.dk,
	jlayton@...hat.com
Subject: Re: [PATCHSET] idr: implement idr_alloc() and convert existing users

Hello,

On Thu, Mar 21, 2013 at 10:06:18AM -0400, J. Bruce Fields wrote:
> > Ooh, BTW, the cyclic allocation is broken.  It's prone to -ENOSPC
> > after the first wraparound.  There are several cyclic users in the
> > kernel and I think it probably would be best to implement cyclic
> > support in idr.
> 
> Are you looking at this, by the way, or do you have any suggestions?
> 
> Wondering if it's something I should try to fix or if I should look into
> converting to some other data structure here.

I am not working on it at the moment but I think the logical thing to
do would be implementing cyclic support in idr and enabling it with,
say, a different initializer - IDR_CYCLIC_INIT() or something.  If you
wanna fix it, please go ahead. :)

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/