linux-kernel - Re: [PATCH] sound: max98090: Remove executable bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Mar 2013 19:44:58 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: max98090: Remove executable bit

On Thu, Mar 21, 2013 at 10:53:13AM -0700, Joe Perches wrote:
> On Thu, 2013-03-21 at 18:44 +0100, Mark Brown wrote:

> > That one needs a bit more taste and thought to work out what's
> > appropraite than can be guaranteed easily with a script, things like
> > working out drive level prefixes for example.

> [perfectly useful git applypatch-msg hook script removed]

No, it really isn't.  Have you tried looking at the output?  It's not
going to do the right thing for the subject line here for example, never
mind any other cases.

> > No, that's going to leave essentially every commit that needs fixing up
> > still needing manual fixup.

> Then I'm sure that's your job as a maintainer
> to modify whatever patches you get to suit your
> taste.

One of the things I'd really expect that a frequent submitter of trivial
patches would be doing is to make an effort to improve the quality of
what is being sent.  If it's at the point where you're sending a lot of
patches and it's more effort to apply them than to review them there's a
problem.

This is something that generally causes no problems for submitters...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)