linux-kernel - Re: VFS deadlock ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwyK4uDgSKUpXBGS5zi16qd8STtrGi3kndunYi40dnj+A@mail.gmail.com>
Date:	Thu, 21 Mar 2013 13:32:45 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Dave Jones <davej@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: VFS deadlock ?

On Thu, Mar 21, 2013 at 1:26 PM, Dave Jones <davej@...hat.com> wrote:
>
> those are qstr's, so I used d_name.name, right ?

Yup. And if you want to, you could do p1->d_parent->d_name.name too,
just to make things obvious. It's technically racy, but by the time
the bug happens, who cares?

> I'd be surprised actually, I've got sysfs excluded from its list of victim files,
> due to unrelated issues still unresolved.  So unless it followed a symlink into
> sys from somewhere in /proc or /dev...
>
> It took a few hours to reproduce last time, I'll increase the number of child
> processes to see if I can trigger it faster now that I have the debug stuff in there.

Hmm, ok. Do you have any network mounts or fuse or other "odd"
filesystems etc? The whole "aliased inodes" thing might come from
something like that.

        Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/