linux-kernel - Re: [patch] drivers, mfd: fix link error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPnjgZ2_AowYw_CsrmhtP5uXRWqYfbgDueNKYF0KAzyVCuf9=A@mail.gmail.com>
Date:	Thu, 21 Mar 2013 13:51:57 -0700
From:	Simon Glass <sjg@...omium.org>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	lk <linux-kernel@...r.kernel.org>
Subject: Re: [patch] drivers, mfd: fix link error

On Thu, Mar 21, 2013 at 12:08 PM, David Rientjes <rientjes@...gle.com> wrote:
> CONFIG_MFD_CROS_EC requires CONFIG_MFD_CORE for a couple of functions that
> are declared but not defined:
>
>         ERROR: "mfd_remove_devices" [drivers/mfd/cros_ec.ko] undefined!
>         ERROR: "mfd_add_devices" [drivers/mfd/cros_ec.ko] undefined!
>
> Fix it by selecting CONFIG_MFD_CORE anytime CONFIG_MFD_CROS_EC is enabled.
>
> Signed-off-by: David Rientjes <rientjes@...gle.com>

Take 2

Acked-by: Simon Glass <sjg@...omium.org>

> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -23,6 +23,7 @@ config MFD_88PM860X
>
>  config MFD_CROS_EC
>         tristate "Support ChromeOS Embedded Controller"
> +       select MFD_CORE
>         help
>           If you say Y here you get support for the ChromeOS Embedded
>           Controller (EC) providing keyboard, battery and power services.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/