linux-kernel - Re: [PATCH] hwrng: exynos - add CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <008301ce268a$74fb9470$5ef2bd50$%han@samsung.com>
Date:	Fri, 22 Mar 2013 08:18:54 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'David Rientjes' <rientjes@...gle.com>,
	'Herbert Xu' <herbert@...dor.apana.org.au>
Cc:	'Andrew Morton' <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, 'Matt Mackall' <mpm@...enic.com>
Subject: Re: [PATCH] hwrng: exynos - add CONFIG_PM_SLEEP to suspend/resume
 functions

On Friday, March 22, 2013 4:17 AM, David Rientjes wrote:
> 
> On Thu, 21 Mar 2013, Herbert Xu wrote:
> 
> > > This patch adds CONFIG_PM_SLEEP to suspend/resume functions to fix
> > > the following build warning when CONFIG_PM_SLEEP is not selected.
> > >
> > > drivers/char/hw_random/exynos-rng.c:147:12: warning: 'exynos_rng_runtime_suspend' defined but not
> used [-Wunused-function]
> > > drivers/char/hw_random/exynos-rng.c:157:12: warning: 'exynos_rng_runtime_resume' defined but not
> used [-Wunused-function]
> > >
> > > Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> >
> > Patch applied.  Thanks.
> 
> Nack, it causes build errors when CONFIG_PM_SLEEP is disabled:
> 
> drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a
> function)
> drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a
> function)

OK, I see.

UNIVERSAL_DEV_PM_OPS is related to both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
Thus, CONFIG_PM_RUNTIME is also necessary.

I will send an additional patch, soon.

Best regards,
Jingoo Han




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/