linux-kernel - Re: [PATCH] cpufreq: stats: do cpufreq_cpu_put() corresponding to cpufreq_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Mar 2013 17:40:25 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Amit Kucheria <amit.kucheria@...aro.org>,
	Robin Randhawa <robin.randhawa@....com>,
	linux-pm@...r.kernel.org, Liviu Dudau <Liviu.Dudau@....com>,
	linux-kernel@...r.kernel.org, cpufreq@...r.kernel.org,
	Steve Bannister <Steve.Bannister@....com>,
	Arvind Chauhan <arvind.chauhan@....com>,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	Charles Garcia-Tobin <charles.garcia-tobin@....com>
Subject: Re: [PATCH] cpufreq: stats: do cpufreq_cpu_put() corresponding to cpufreq_cpu_get

On 22 March 2013 17:42, Rafael J. Wysocki <rjw@...k.pl> wrote:
> Which would be useful to write in the changelog, wouldn't it?

Hmm..

copy-paste with gmail is also broken, so find it attached too.

New change log, no change in patch and you can trust me on that :)

----------x-------------x--------

>From 034e5ac4cccd09872592a46decd38d5f24047f10 Mon Sep 17 00:00:00 2001
Message-Id: <034e5ac4cccd09872592a46decd38d5f24047f10.1363954124.git.viresh.kumar@...aro.org>
From: Viresh Kumar <viresh.kumar@...aro.org>
Date: Fri, 22 Mar 2013 15:15:48 +0530
Subject: [PATCH] cpufreq: stats: do cpufreq_cpu_put() corresponding to
 cpufreq_cpu_get

In cpufreq_stats_free_sysfs() we aren't balancing calls to cpufreq_cpu_get()
with cpufreq_cpu_put(). This will never let us have ref count to policy->kobj as
zero.

We will get a hang if somehow cpufreq_driver_unregister() is called. And that
can happen when we compile our driver as module and insmod/rmmod it.

Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

Download attachment "0001-cpufreq-stats-do-cpufreq_cpu_put-corresponding-to-cp.patch" of type "application/octet-stream" (1634 bytes)