linux-kernel - Re: [PATCH linux-pm] cpufreq: governors: Fix calculation of wall time in get_cpu_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1799487.FNztk3vCxS@vostro.rjw.lan>
Date:	Fri, 22 Mar 2013 14:24:11 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Stratos Karafotis <stratosk@...aphore.gr>
Cc:	cpufreq@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-pm] cpufreq: governors: Fix calculation of wall time in get_cpu_idle_time

On Friday, March 22, 2013 09:16:37 AM Stratos Karafotis wrote:
> With commit 8755a8ae31ba213db196324011a0da2a85807f25 the wall in
> get_cpu_idle_time is not calculated, when we use ondemand with
> io_is_busy = 1, preventing the CPU to increase to max frequency.
> 
> Properly, calculate wall time when we use io_is_busy.
> 
> Signed-off-by: Stratos Karafotis <stratosk@...aphore.gr>

I folded the change below into the original patch.

Thanks,
Rafael


> ---
>  drivers/cpufreq/cpufreq_governor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c
> index b49d45d..41e5e56 100644
> --- a/drivers/cpufreq/cpufreq_governor.c
> +++ b/drivers/cpufreq/cpufreq_governor.c
> @@ -53,7 +53,7 @@ static inline u64 get_cpu_idle_time_jiffy(unsigned int cpu, u64 *wall)
>  
>  u64 get_cpu_idle_time(unsigned int cpu, u64 *wall, int io_busy)
>  {
> -	u64 idle_time = get_cpu_idle_time_us(cpu, NULL);
> +	u64 idle_time = get_cpu_idle_time_us(cpu, io_busy ? wall : NULL);
>  
>  	if (idle_time == -1ULL)
>  		return get_cpu_idle_time_jiffy(cpu, wall);
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/