| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <514BC39F.6050209@gmail.com> Date: Thu, 21 Mar 2013 21:36:15 -0500 From: Rob Herring <robherring2@...il.com> To: Russell King - ARM Linux <linux@....linux.org.uk> CC: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org, Arnd Bergmann <arnd@...db.de>, linus.walleij@...aro.org, haojian.zhuang@...aro.org, pawel.moll@....com, john.stultz@...aro.org, tglx@...utronix.de, Rob Herring <rob.herring@...xeda.com> Subject: Re: [PATCH 02/11] ARM: remove extra timer-sp control register clearing On 03/21/2013 02:23 PM, Russell King - ARM Linux wrote: > On Wed, Mar 20, 2013 at 05:54:02PM -0500, Rob Herring wrote: >> From: Rob Herring <rob.herring@...xeda.com> >> >> The timer-sp initialization code clears the control register before >> initializing the timers, so every platform doing this is redundant. >> >> For unused timers, we should not care what state they are in. > > NAK. We do care what state they're in. What if they have their interrupt > enable bit set, and IRQ is shared with the clock event timer? > > No, this patch is just wrong. Okay, I can have the timer init function clear the register in the case that even when the timer is unused. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists