linux-kernel - Re: [PATCH] cpufreq/intel_pstate: Fix calculation of current frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2316804.ObH9JhORys@vostro.rjw.lan>
Date:	Sat, 23 Mar 2013 01:14:35 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	dirk.brandewie@...il.com
Cc:	linux-kernel@...r.kernel.org, cpufreq@...r.kernel.org,
	Dirk Brandewie <dirk.j.brandewie@...el.com>
Subject: Re: [PATCH] cpufreq/intel_pstate: Fix calculation of current frequency

On Friday, March 22, 2013 10:51:05 AM dirk.brandewie@...il.com wrote:
> From: Dirk Brandewie <dirk.brandewie@...il.com>
> 
> Use the correct pstate value to calculate the effective frequency.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=923942
> Reported-by: Satish Balay <balay@...tmail.fm>
> 
> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@...el.com>

Well, another quick fix for v3.9 I suppose?

May I please be sent CCs of such things to at least one of my addresses?

Rafael


> ---
>  drivers/cpufreq/intel_pstate.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index e84af66..ad72922 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -454,7 +454,7 @@ static inline void intel_pstate_calc_busy(struct cpudata *cpu,
>  					sample->idletime_us * 100,
>  					sample->duration_us);
>  	core_pct = div64_u64(sample->aperf * 100, sample->mperf);
> -	sample->freq = cpu->pstate.turbo_pstate * core_pct * 1000;
> +	sample->freq = cpu->pstate.max_pstate * core_pct * 1000;
>  
>  	sample->core_pct_busy = div_s64((sample->pstate_pct_busy * core_pct),
>  					100);
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/