| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130323211957.GC9138@mwanda> Date: Sun, 24 Mar 2013 00:19:57 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Kumar amit mehta <gmate.amit@...il.com> Cc: eilong@...adcom.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] bnx2x: fix assignment of signed expression to unsigned variable On Sat, Mar 23, 2013 at 01:45:11PM -0700, Kumar amit mehta wrote: > On Sat, Mar 23, 2013 at 10:56:47PM +0300, Dan Carpenter wrote: > > > > The fix for this is more involved. The function prototype should > > be changed to return an int. The caller should be updated to check > > for errors. > > > I wonder, why these callbacks are restricting the lower layers to return > only unsigned values, However Updating the prototype doesn't seem a good idea as > then it would require changes in various existing drivers. Yes. Everything will need to be updated. I've known this code is buggy for years but I've never tried patching it because I'm very lazy. :) But actually it's only three drivers I think: bnx2x, ixgbe, and mlx4. I suspect that most of the functions always return zero and won't need to be modified. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists