linux-kernel - Re: [PATCH 11/11] Create module providing optimized SHA512 routines using SSSE3, AVX or AVX2 instructions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <514EE556.7020004@iki.fi>
Date:	Sun, 24 Mar 2013 13:36:54 +0200
From:	Jussi Kivilinna <jussi.kivilinna@....fi>
To:	Tim Chen <tim.c.chen@...ux.intel.com>
CC:	Herbert Xu <herbert@...dor.apana.org.au>,
	"H. Peter Anvin" <hpa@...or.com>,
	"David S.Miller" <davem@...emloft.net>,
	Kirk Yap <kirk.s.yap@...el.com>,
	David Cote <david.m.cote@...el.com>,
	James Guilford <james.guilford@...el.com>,
	Wajdi Feghali <wajdi.k.feghali@...el.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-crypto@...r.kernel.org
Subject: Re: [PATCH 11/11] Create module providing optimized SHA512 routines
 using SSSE3, AVX or AVX2 instructions.

On 22.03.2013 23:29, Tim Chen wrote:
> We added glue code and config options to create crypto
> module that uses SSE/AVX/AVX2 optimized SHA512 x86_64 assembly routines.
> 
> Signed-off-by: Tim Chen <tim.c.chen@...ux.intel.com>
> ---
>  arch/x86/crypto/Makefile            |   2 +
>  arch/x86/crypto/sha512_ssse3_glue.c | 276 ++++++++++++++++++++++++++++++++++++
>  crypto/Kconfig                      |  11 ++
>  3 files changed, 289 insertions(+)
>  create mode 100644 arch/x86/crypto/sha512_ssse3_glue.c
> 
> diff --git a/arch/x86/crypto/Makefile b/arch/x86/crypto/Makefile
> index 02a664a..7d12625 100644
> --- a/arch/x86/crypto/Makefile
> +++ b/arch/x86/crypto/Makefile
> @@ -28,6 +28,7 @@ obj-$(CONFIG_CRYPTO_GHASH_CLMUL_NI_INTEL) += ghash-clmulni-intel.o
>  obj-$(CONFIG_CRYPTO_CRC32C_INTEL) += crc32c-intel.o
>  obj-$(CONFIG_CRYPTO_SHA1_SSSE3) += sha1-ssse3.o
>  obj-$(CONFIG_CRYPTO_SHA256_SSSE3) += sha256-ssse3.o
> +obj-$(CONFIG_CRYPTO_SHA512_SSSE3) += sha512-ssse3.o
>  
>  aes-i586-y := aes-i586-asm_32.o aes_glue.o
>  twofish-i586-y := twofish-i586-asm_32.o twofish_glue.o
> @@ -54,3 +55,4 @@ sha1-ssse3-y := sha1_ssse3_asm.o sha1_ssse3_glue.o
>  crc32c-intel-y := crc32c-intel_glue.o
>  crc32c-intel-$(CONFIG_CRYPTO_CRC32C_X86_64) += crc32c-pcl-intel-asm_64.o
>  sha256-ssse3-y := sha256-ssse3-asm.o sha256-avx-asm.o sha256-avx2-asm.o sha256_ssse3_glue.o
> +sha512-ssse3-y := sha512-ssse3-asm.o sha512-avx-asm.o sha512-avx2-asm.o sha512_ssse3_glue.o
> diff --git a/arch/x86/crypto/sha512_ssse3_glue.c b/arch/x86/crypto/sha512_ssse3_glue.c
> new file mode 100644
> index 0000000..25a2e07
> --- /dev/null
> +++ b/arch/x86/crypto/sha512_ssse3_glue.c

...snip..

> +#include <linux/string.h>
> +
> +asmlinkage void sha512_transform_ssse3(const char *data, u64 *digest,
> +				     u64 rounds);
> +#ifdef CONFIG_AS_AVX
> +asmlinkage void sha512_transform_avx(const char *data, u64 *digest,
> +				     u64 rounds);
> +asmlinkage void sha512_transform_rorx(const char *data, u64 *digest,
> +				     u64 rounds);
> +#endif
> +

Is CONFIG_AS_AVX enough to ensure that rorx is supported by assembler?

You also have #ifdef CONFIG_AS_AVX / #endif missing in 'sha256-avx-asm.S', 'sha256-avx2-asm.S', 'sha512-avx-asm.S' and 'sha512-avx2-asm.S'.

-Jussi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/