linux-kernel - RE: [PATCH v2] bnx2x: fix assignment of signed expression to unsigned variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <504C9EFCA2D0054393414C9CB605C37F20BEBB46@SJEXCHMB06.corp.ad.broadcom.com>
Date:	Sun, 24 Mar 2013 08:00:10 +0000
From:	"Dmitry Kravkov" <dmitry@...adcom.com>
To:	"Kumar Amit Mehta" <gmate.amit@...il.com>,
	"Eilon Greenstein" <eilong@...adcom.com>
cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH v2] bnx2x: fix assignment of signed expression to
 unsigned variable

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On Behalf Of Kumar Amit Mehta
> Sent: Sunday, March 24, 2013 8:10 AM
> To: Eilon Greenstein
> Cc: davem@...emloft.net; dan.carpenter@...cle.com; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; kernel-
> janitors@...r.kernel.org
> Subject: [PATCH v2] bnx2x: fix assignment of signed expression to unsigned variable
> 
> fix for incorrect assignment of signed expression to unsigned variable.
> 
> Signed-off-by: Kumar Amit Mehta <gmate.amit@...il.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c |   18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c
> index 5682054..91ecd6a 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c
> @@ -2139,12 +2139,12 @@ static u8 bnx2x_dcbnl_get_cap(struct net_device *netdev, int capid, u8 *cap)
>  			break;
>  		default:
>  			BNX2X_ERR("Non valid capability ID\n");
> -			rval = -EINVAL;
> +			rval = 1;
>  			break;
>  		}
>  	} else {
>  		DP(BNX2X_MSG_DCB, "DCB disabled\n");
> -		rval = -EINVAL;
> +		rval = 1;
>  	}
> 
>  	DP(BNX2X_MSG_DCB, "capid %d:%x\n", capid, *cap);
> @@ -2170,12 +2170,12 @@ static int bnx2x_dcbnl_get_numtcs(struct net_device *netdev, int tcid, u8 *num)
>  			break;
>  		default:
>  			BNX2X_ERR("Non valid TC-ID\n");
> -			rval = -EINVAL;
> +			rval = 1;
>  			break;
>  		}
>  	} else {
>  		DP(BNX2X_MSG_DCB, "DCB disabled\n");
> -		rval = -EINVAL;
> +		rval = 1;
>  	}
> 
>  	return rval;
> @@ -2188,7 +2188,7 @@ static int bnx2x_dcbnl_set_numtcs(struct net_device *netdev, int tcid, u8 num)
>  	return -EINVAL;
>  }
> 
> -static u8  bnx2x_dcbnl_get_pfc_state(struct net_device *netdev)
> +static u8 bnx2x_dcbnl_get_pfc_state(struct net_device *netdev)
>  {
>  	struct bnx2x *bp = netdev_priv(netdev);
>  	DP(BNX2X_MSG_DCB, "state = %d\n", bp->dcbx_local_feat.pfc.enabled);
> @@ -2390,12 +2390,12 @@ static u8 bnx2x_dcbnl_get_featcfg(struct net_device *netdev, int featid,
>  			break;
>  		default:
>  			BNX2X_ERR("Non valid featrue-ID\n");
> -			rval = -EINVAL;
> +			rval = 1;
>  			break;
>  		}
>  	} else {
>  		DP(BNX2X_MSG_DCB, "DCB disabled\n");
> -		rval = -EINVAL;
> +		rval = 1;
>  	}
> 
>  	return rval;
> @@ -2431,12 +2431,12 @@ static u8 bnx2x_dcbnl_set_featcfg(struct net_device *netdev, int featid,
>  			break;
>  		default:
>  			BNX2X_ERR("Non valid featrue-ID\n");
> -			rval = -EINVAL;
> +			rval = 1;
>  			break;
>  		}
>  	} else {
>  		DP(BNX2X_MSG_DCB, "dcbnl call not valid\n");
> -		rval = -EINVAL;
> +		rval = 1;
>  	}
> 
>  	return rval;
> --
> 1.7.9.5

Kumar,  thanks!

Acked-by: Dmitry Kravkov <dmitry@...adcom.com>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/