linux-kernel - Re: OOM triggered with plenty of memory free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130325022445.GH29157@marvin.atrad.com.au>
Date:	Mon, 25 Mar 2013 12:54:45 +1030
From:	Jonathan Woithe <jwoithe@...ad.com.au>
To:	Raymond Jennings <shentino@...il.com>
Cc:	Hillf Danton <dhillf@...il.com>,
	David Rientjes <rientjes@...gle.com>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jonathan Woithe <jwoithe@...ad.com.au>
Subject: Re: OOM triggered with plenty of memory free

This post ties up a few loose ends in this thread which remained after my
21 March 2013 post.

 * The memory leak was not present in 2.6.36.

 * The patch to 2.6.35.11 at the end of this email (based on
   48e6b121605512d87f8da1ccd014313489c19630 from linux-stable) resolves the
   memory leak in 2.6.35.11.

This gives us a workable solution while we await fixes to current mainline
in the r8169 driver.  Once that's done we can revalidate our systems against
a more recent kernel and start shipping that.

Thanks to those who assisted with this issue.

Regards
  jonathan

--- a/net/netlink/af_netlink.c	2013-03-25 10:32:15.365781434 +1100
+++ b/net/netlink/af_netlink.c	2013-03-25 10:32:15.373782107 +1100
@@ -1387,6 +1387,8 @@ static int netlink_sendmsg(struct kiocb
 	err = netlink_unicast(sk, skb, dst_pid, msg->msg_flags&MSG_DONTWAIT);

 out:
+	scm_destroy(siocb->scm);
+	siocb->scm = NULL;
 	return err;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/