linux-kernel - [Suggestion] scripts/checkpatch.pl: an issue about checking failed for a patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Mar 2013 10:48:28 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	apw@...onical.com, Joe Perches <joe@...ches.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [Suggestion] scripts/checkpatch.pl: an issue about checking failed
 for a patch

Hello Maintainers:

  when I use ./scripts/checkpatch.pl to check a patch,
    it reports a style issue.
    but after check, I can not find issue.
      (I use "static inline void" instead of "static void inline")

  please help check.

  thanks.


the related issue is:

--------------------------------------------------------------------------------------------------------------------------------
[root@...enlinux linux-next]# ./scripts/checkpatch.pl  /tmp/0003-include-linux-platform_data-beautify-code-inline-is-.patch 
WARNING: line over 80 characters
#22: FILE: include/linux/platform_data/usb-ohci-s3c2410.h:34:
+static inline void s3c2410_usb_report_oc(struct s3c2410_hcd_info *info, int ports)

total: 0 errors, 1 warnings, 8 lines checked

/tmp/0003-include-linux-platform_data-beautify-code-inline-is-.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
--------------------------------------------------------------------------------------------------------------------------------




the related patch is :
  ("/tmp/0003-include-linux-platform_data-beautify-code-inline-is-.patch")


>From e8be21fd7b7126847a6ddfea5ac002c2ca2ca194 Mon Sep 17 00:00:00 2001
From: Chen Gang <gang.chen@...anux.com>
Date: Mon, 25 Mar 2013 10:25:53 +0800
Subject: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'

  better to let 'inline' in front of 'void'

Signed-off-by: Chen Gang <gang.chen@...anux.com>
---
 include/linux/platform_data/usb-ohci-s3c2410.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/platform_data/usb-ohci-s3c2410.h b/include/linux/platform_data/usb-ohci-s3c2410.h
index 7fa1fbe..cc7554a 100644
--- a/include/linux/platform_data/usb-ohci-s3c2410.h
+++ b/include/linux/platform_data/usb-ohci-s3c2410.h
@@ -31,7 +31,7 @@ struct s3c2410_hcd_info {
 	void		(*report_oc)(struct s3c2410_hcd_info *, int ports);
 };
 
-static void inline s3c2410_usb_report_oc(struct s3c2410_hcd_info *info, int ports)
+static inline void s3c2410_usb_report_oc(struct s3c2410_hcd_info *info, int ports)
 {
 	if (info->report_oc != NULL) {
 		(info->report_oc)(info, ports);
-- 
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/