linux-kernel - Re: [PATCH] PowerPC:kernel: section mismatch from smp_release_cpus to __initdata spinning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <514FD27B.6050706@asianux.com>
Date:	Mon, 25 Mar 2013 12:28:43 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	"paulus@...ba.org" <paulus@...ba.org>, michael@...erman.id.au,
	dhowells@...hat.com, geoff@...radead.org,
	"sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
	Michael Neuling <mikey@...ling.org>
CC:	linuxppc-dev@...ts.ozlabs.org,
	"linux-kernel@...r.kernel.org >> \"linux-kernel@...r.kernel.org\"" 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PowerPC:kernel: section mismatch from smp_release_cpus
 to __initdata spinning_secondaries

Hello Maintainers:

  could you help check this patch whether is ok ?

  thanks.


On 2013年03月20日 14:30, Chen Gang wrote:
> 
>   the smp_release_cpus is a normal funciton and called in normal environments,
>   but it calls the __initdata spinning_secondaries.
>   need modify spinning_secondaries to match smp_release_cpus.
> 
> the related warning:
>   (the linker report boot_paca.33377, but it should be spinning_secondaries)
> 
> -----------------------------------------------------------------------------
> 
> WARNING: arch/powerpc/kernel/built-in.o(.text+0x23176): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377
> The function .smp_release_cpus() references
> the variable __initdata boot_paca.33377.
> This is often because .smp_release_cpus lacks a __initdata 
> annotation or the annotation of boot_paca.33377 is wrong.
> 
> WARNING: arch/powerpc/kernel/built-in.o(.text+0x231fe): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377
> The function .smp_release_cpus() references
> the variable __initdata boot_paca.33377.
> This is often because .smp_release_cpus lacks a __initdata 
> annotation or the annotation of boot_paca.33377 is wrong.
> 
> -----------------------------------------------------------------------------
> 
> 
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  arch/powerpc/kernel/setup_64.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
> index 75fbaceb..e8a2f2e 100644
> --- a/arch/powerpc/kernel/setup_64.c
> +++ b/arch/powerpc/kernel/setup_64.c
> @@ -76,7 +76,7 @@
>  #endif
>  
>  int boot_cpuid = 0;
> -int __initdata spinning_secondaries;
> +int spinning_secondaries;
>  u64 ppc64_pft_size;
>  
>  /* Pick defaults since we might want to patch instructions
> 


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/