linux-kernel - Re: [PATCH] staging: lirc: remove dead code

Open Source and information security mailing list archives

Message-ID: <CAHj3AVn83fum-2BQnEKxxajdL=VLrdNQGQ2cWf7dzOYbVHiqQw@mail.gmail.com>
Date:	Mon, 25 Mar 2013 13:40:35 +0400
From:	Denis Kirjanov <kirjanov@...il.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Jarod Wilson <jarod@...sonet.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH] staging: lirc: remove dead code

Just found that the exactly the same patch has been posted a while ago:
http://driverdev.linuxdriverproject.org/pipermail/devel/2012-November/033623.html

On 3/25/13, Paul Bolle <pebolle@...cali.nl> wrote:
> lirc uses the CONFIG_SA1100_BITSY Kconfig macro. But its Kconfig symbol
> was removed in v2.4.13. So we can remove a few lines of dead code.
>
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> Untested, but of rather low risk. Note that support for the
> machine_is_bitsy() macro was already removed in v2.4.10.
>
>  drivers/staging/media/lirc/lirc_sir.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_sir.c
> b/drivers/staging/media/lirc/lirc_sir.c
> index 63a554c..f781c53 100644
> --- a/drivers/staging/media/lirc/lirc_sir.c
> +++ b/drivers/staging/media/lirc/lirc_sir.c
> @@ -787,12 +787,6 @@ static int init_hardware(void)
>  	spin_lock_irqsave(&hardware_lock, flags);
>  	/* reset UART */
>  #ifdef LIRC_ON_SA1100
> -#ifdef CONFIG_SA1100_BITSY
> -	if (machine_is_bitsy()) {
> -		pr_info("Power on IR module\n");
> -		set_bitsy_egpio(EGPIO_BITSY_IR_ON);
> -	}
> -#endif
>  #ifdef CONFIG_SA1100_COLLIE
>  	sa1100_irda_set_power_collie(3);	/* power on */
>  #endif
> @@ -942,10 +936,6 @@ static void drop_hardware(void)
>  	Ser2UTCR3 = sr.utcr3;
>
>  	Ser2HSCR0 = sr.hscr0;
> -#ifdef CONFIG_SA1100_BITSY
> -	if (machine_is_bitsy())
> -		clr_bitsy_egpio(EGPIO_BITSY_IR_ON);
> -#endif
>  #ifdef CONFIG_SA1100_COLLIE
>  	sa1100_irda_set_power_collie(0);	/* power off */
>  #endif
> --
> 1.7.11.7
>
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>


-- 
Regards,
Denis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives