linux-kernel - RE: [PATCH] ARM: EXYNOS: Add missing semicolons in exynos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <177201ce293e$35753cf0$a05fb6d0$%kim@samsung.com>
Date:	Mon, 25 Mar 2013 18:50:40 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Doug Anderson' <dianders@...omium.org>
Cc:	'Thomas Abraham' <thomas.abraham@...aro.org>,
	'Stephen Warren' <swarren@...dia.com>,
	'Changhwan Youn' <chaos.youn@...sung.com>,
	'Arnd Bergmann' <arnd@...db.de>,
	'Olof Johansson' <olof@...om.net>,
	'Simon Glass' <sjg@...omium.org>,
	'John Stultz' <john.stultz@...aro.org>,
	'Thomas Gleixner' <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: RE: [PATCH] ARM: EXYNOS: Add missing semicolons in exynos_mct.c

Doug Anderson wrote:
> 
> The CLOCKSOURCE_OF_DECLARE lines were added without a semicolon at the
> end.  On my system this causes a compile-time error that looks like:
> 
>  .../drivers/clocksource/exynos_mct.c:557:202: warning: comparison of
> distinct pointer types lacks a cast [enabled by default]
>  .../drivers/clocksource/exynos_mct.c:558:1: error: expected ',' or ';'
> before 'static'
> 
> The error didn't show up till now because there was an extra semicolon

Yeah.

> at end of the CLOCKSOURCE_OF_DECLARE definition that was removed by
> Arnd Bergmann in "clocksource: make CLOCKSOURCE_OF_DECLARE type safe"
> 
OK, thanks.

> Signed-off-by: Doug Anderson <dianders@...omium.org>
> ---
>  drivers/clocksource/exynos_mct.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clocksource/exynos_mct.c
> b/drivers/clocksource/exynos_mct.c
> index 203ac05..106228d 100644
> --- a/drivers/clocksource/exynos_mct.c
> +++ b/drivers/clocksource/exynos_mct.c
> @@ -554,5 +554,5 @@ void __init mct_init(void)
>  	exynos4_clocksource_init();
>  	exynos4_clockevent_init();
>  }
> -CLOCKSOURCE_OF_DECLARE(exynos4210, "samsung,exynos4210-mct", mct_init)
> -CLOCKSOURCE_OF_DECLARE(exynos4412, "samsung,exynos4412-mct", mct_init)
> +CLOCKSOURCE_OF_DECLARE(exynos4210, "samsung,exynos4210-mct", mct_init);
> +CLOCKSOURCE_OF_DECLARE(exynos4412, "samsung,exynos4412-mct", mct_init);
> --
> 1.8.1.3

Applied, thanks.

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/