linux-kernel - Re: [PATCH v5 2/2] perf: add sysfs entry to adjust multiplexing interval per PMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1364211788.5053.3.camel@laptop>
Date:	Mon, 25 Mar 2013 12:43:08 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, ak@...ux.intel.com,
	acme@...hat.com, jolsa@...hat.com, namhyung.kim@....com
Subject: Re: [PATCH v5 2/2] perf: add sysfs entry to adjust multiplexing
 interval per PMU

On Fri, 2013-03-22 at 11:51 +0100, Stephane Eranian wrote:
> In the 4th version, we renamed the sysfs file to be more
> consistent with the other /proc/sys/kernel entries for
> perf_events.

>  static struct device_attribute pmu_dev_attrs[] = {
> -       __ATTR_RO(type),
> -       __ATTR_NULL,
> +       __ATTR_RO(type),
> +       __ATTR_RW(perf_event_mux_interval_ms),
> +       __ATTR_NULL,
>  };

but but but, the file doesn't live in /proc/sys/kernel/, its in
/sys/bus/event_source/devices/*/$foo and none of the files there are
perf_event_* prefixed.

Other than that, the patches look fine.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/