linux-kernel - Re: [PATCH 08/10] ARM: sunxi: dt: Update interrupt controller compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51505825.2060805@gmail.com>
Date:	Mon, 25 Mar 2013 08:59:01 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
CC:	linux-arm-kernel@...ts.infradead.org, shuge@...winnertech.com,
	linux-kernel@...r.kernel.org,
	Russell King <linux@....linux.org.uk>, kevin@...winnertech.com,
	sunny@...winnertech.com
Subject: Re: [PATCH 08/10] ARM: sunxi: dt: Update interrupt controller compatible
 string

On 03/25/2013 08:30 AM, Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> ---
>  arch/arm/boot/dts/sun4i-a10.dtsi |    2 +-
>  arch/arm/boot/dts/sun5i-a13.dtsi |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index be71782..805d704 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -121,7 +121,7 @@
>  		ranges;
>  
>  		intc: interrupt-controller@...20400 {
> -			compatible = "allwinner,sunxi-ic";
> +			compatible = "allwinner,sun4i-ic";

Generally speaking, this is a bad thing to do. This breaks compatibility
between dtb and kernel versions. If that breakage is not yet a concern
for sunxi, then it is okay.

Also, I don't see any documentation updates for any of these changes.

Rob

>  			reg = <0x01c20400 0x400>;
>  			interrupt-controller;
>  			#interrupt-cells = <1>;
> diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi
> index 7a81aaf..760222c 100644
> --- a/arch/arm/boot/dts/sun5i-a13.dtsi
> +++ b/arch/arm/boot/dts/sun5i-a13.dtsi
> @@ -122,7 +122,7 @@
>  		ranges;
>  
>  		intc: interrupt-controller@...20400 {
> -			compatible = "allwinner,sunxi-ic";
> +			compatible = "allwinner,sun4i-ic";
>  			reg = <0x01c20400 0x400>;
>  			interrupt-controller;
>  			#interrupt-cells = <1>;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/