linux-kernel - Re: [PATCH 06/11] Create module providing optimized SHA256 routines using SSSE3, AVX or AVX2 instructions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1364244040.8972.71.camel@schen9-DESK>
Date:	Mon, 25 Mar 2013 13:40:40 -0700
From:	Tim Chen <tim.c.chen@...ux.intel.com>
To:	Jussi Kivilinna <jussi.kivilinna@....fi>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	"H. Peter Anvin" <hpa@...or.com>,
	"David S.Miller" <davem@...emloft.net>,
	Kirk Yap <kirk.s.yap@...el.com>,
	David Cote <david.m.cote@...el.com>,
	James Guilford <james.guilford@...el.com>,
	Wajdi Feghali <wajdi.k.feghali@...el.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-crypto@...r.kernel.org
Subject: Re: [PATCH 06/11] Create module providing optimized SHA256
 routines using SSSE3, AVX or AVX2 instructions.

On Sun, 2013-03-24 at 23:52 +0200, Jussi Kivilinna wrote:
> On 22.03.2013 23:29, Tim Chen wrote:
> > We added glue code and config options to create crypto
> > module that uses SSE/AVX/AVX2 optimized SHA256 x86_64 assembly routines.
> > 
> > Signed-off-by: Tim Chen <tim.c.chen@...ux.intel.com>
> 
> ..snip..
> 
> > diff --git a/arch/x86/crypto/sha256_ssse3_glue.c b/arch/x86/crypto/sha256_ssse3_glue.c
> > new file mode 100644
> > index 0000000..5876a19
> > --- /dev/null
> > +++ b/arch/x86/crypto/sha256_ssse3_glue.c
> 
> ..snip..
> 
> > +static int __init sha256_ssse3_mod_init(void)
> > +{
> > +	/* test for SSE3 first */
> > +	if (cpu_has_xmm3)
> > +		sha256_transform_asm = sha256_transform_ssse3;
> > +
> 
> This causes OOPS on my computer. Maybe use 'cpu_has_ssse3' instead?
> 

Thanks and appreciate your feedback.  I'll be sending an update of the
patch series to address the issues.

Tim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/